Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add java details as tags to the build scan #526

Merged
merged 1 commit into from
Mar 5, 2023
Merged

Conversation

timyates
Copy link
Contributor

@timyates timyates commented Mar 3, 2023

When investigating flakiness, it's useful to see (at a glance) whether there's some commonality to the flaky builds.

This PR adds two tags to build scans.

The current jdk vendor taken from the system properties, and the current major Java version running the build.

The vendor is munged so non alphanumeric chars are replaced by underscores, ie: 'Azul Systems, Inc.' becomes 'Azul_Systems_Inc_'

When investigating flakiness, it's useful to see (at a glance) whether there's some commonality to the flaky builds.

This PR adds two tags to build scans.

The current jdk vendor taken from the system properties, and the current major Java version running the build.

The vendor is munged so non alphanumeric chars are replaced by underscores, ie: 'Azul Systems, Inc.' becomes 'Azul_Systems_Inc_'
@timyates timyates added the enhancement New feature or request label Mar 3, 2023
@timyates timyates requested a review from melix March 3, 2023 17:26
@timyates timyates self-assigned this Mar 3, 2023
@melix melix added this to the 5.4.7 milestone Mar 3, 2023
@sdelamo sdelamo merged commit 2923d8d into 5.4.x Mar 5, 2023
@sdelamo sdelamo deleted the java-version-tags branch March 5, 2023 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants