Update checkstyle to support Java17 enhanced instanceof #422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I tried versions after this, but then I started seeing
```
Caused by: com.puppycrawl.tools.checkstyle.api.CheckstyleException: Property 'excludeScope' does not exist, please check the documentation
at com.puppycrawl.tools.checkstyle.api.AutomaticBean.tryCopyProperty(AutomaticBean.java:227)
at com.puppycrawl.tools.checkstyle.api.AutomaticBean.configure(AutomaticBean.java:194)
at com.puppycrawl.tools.checkstyle.TreeWalker.setupChild(TreeWalker.java:123)
```
This was the latest version that supported enhanced instanceof, and still worked
See https://github.com/micronaut-projects/micronaut-session/pull/3/files#diff-7e845743b3275ae8a6a36524c32064120f1a55235372b55a5f8d2a6b685b919fR59
melix
approved these changes
Oct 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried versions after this, but then I started seeing
This was the latest version that supported enhanced instanceof, and still worked
See https://github.com/micronaut-projects/micronaut-session/pull/3/files#diff-7e845743b3275ae8a6a36524c32064120f1a55235372b55a5f8d2a6b685b919fR59