Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to byte buddy #421

Merged
merged 1 commit into from
Oct 14, 2022
Merged

Switch to byte buddy #421

merged 1 commit into from
Oct 14, 2022

Conversation

timyates
Copy link
Contributor

We had issues with Groovy 4, cgilib, Spock and Java 17

https://github.com/micronaut-projects/micronaut-kubernetes/pull/510\#issuecomment-1278775288

This pr switches cgilib to byte buddy, as cgilib is no longer maintained

We had issues with Groovy 4, cgilib, Spock and Java 17

https://github.com/micronaut-projects/micronaut-kubernetes/pull/510\#issuecomment-1278775288

This pr switches cgilib to byte buddy, as cgilib is no longer maintained
@timyates timyates added this to the 6.0.1 milestone Oct 14, 2022
@timyates timyates requested a review from melix October 14, 2022 10:59
@timyates timyates self-assigned this Oct 14, 2022
Copy link
Contributor

@melix melix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we're moving from cglib to bytebuddy (I had no idea one was a direct replacement for the other), I wonder if we should make the addition optional, since probably not all modules need this. But it's fine to merge as is.

@timyates
Copy link
Contributor Author

Yeah, TIL Spock now recommend bytebuddy

@timyates timyates merged commit 02b8016 into master Oct 14, 2022
@timyates timyates deleted the byte-buddy branch October 14, 2022 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants