Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the dependency updates plugin #408

Merged
merged 1 commit into from
Sep 28, 2022
Merged

Conversation

melix
Copy link
Contributor

@melix melix commented Sep 28, 2022

We don't use that plugin anymore. In order to make sure workflows still work in case they are still using this task, a DeprecatedTask has been added, which warns to remove the use of the task.

We don't use that plugin anymore. In order to make sure workflows still
work in case they are still using this task, a `DeprecatedTask` has been
added, which warns to remove the use of the task.
@melix melix added the type: breaking Introduces a breaking change label Sep 28, 2022
@melix melix added this to the 6.0.0 milestone Sep 28, 2022
@melix melix requested a review from alvarosanchez September 28, 2022 09:00
@melix melix self-assigned this Sep 28, 2022
tasks.named("useLatestVersions") {
updateRootProperties = true
tasks.register("dependencyUpdates", DeprecatedTask) {
it.message.set("The dependencyUpdates task is scheduled for removal")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, the task has actually been removed no?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A task is still present, so calling it wouldn't fail, vs completely removing which would cause Gradle to bark.

@melix melix merged commit 19edf1e into master Sep 28, 2022
@melix melix deleted the cc/remove-ben-manes-plugin branch September 28, 2022 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: breaking Introduces a breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants