Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Groovy 4 update for internal builds #400

Merged
merged 3 commits into from
Sep 23, 2022
Merged

Groovy 4 update for internal builds #400

merged 3 commits into from
Sep 23, 2022

Conversation

timyates
Copy link
Contributor

Current based on master so CI runs.

I think this is all that is required...

It's really hard to test, as we don't have a version to functionally test against 🤔

This also fixes a clash of Jars that was causing local tests to fail

@timyates timyates changed the base branch from master to 6.0.x September 22, 2022 16:19
@timyates timyates marked this pull request as ready for review September 22, 2022 16:19
@timyates timyates requested a review from melix September 22, 2022 16:19
@timyates
Copy link
Contributor Author

Not sure this needs a 6.0.x release now, as it should work for groovy 3 and 4 🤔

@timyates timyates self-assigned this Sep 22, 2022
Copy link
Contributor

@melix melix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So after talking with @timyates we agreed on merging this PR, then I'm going to do some more cleanup of the build plugins, to get rig of suspicious dependencies or rules.

@melix melix merged commit 1de9687 into 6.0.x Sep 23, 2022
@melix melix deleted the groovy-4 branch September 23, 2022 14:09
@melix melix added this to the 6.0.0 milestone Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants