Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check version catalog compatibility #370

Merged
merged 1 commit into from
Jul 22, 2022
Merged

Check version catalog compatibility #370

merged 1 commit into from
Jul 22, 2022

Conversation

melix
Copy link
Contributor

@melix melix commented Jul 21, 2022

This plugin adds a "binary" compatibibility check for the published
version catalogs. It will check that the newly published catalogs
doesn't miss entries which existed previously. If the change is
intentional, it is possible to explicitly accept regressions by
adding them to the suppressions block of the micronautBom
extension.

The tests are using "real" catalog files, the baseline is 3.5.3
and the baseline is the current 3.6.0 branch state. It already
shows that we discover problems using this.

This plugin adds a "binary" compatibibility check for the published
version catalogs. It will check that the newly published catalogs
doesn't miss entries which existed previously. If the change is
intentional, it is possible to explicitly accept regressions by
adding them to the `suppressions` block of the `micronautBom`
extension.

The tests are using "real" catalog files, the baseline is 3.5.3
and the baseline is the current 3.6.0 branch state. It already
shows that we discover problems using this.
@melix melix added the type: improvement A minor improvement to an existing feature label Jul 21, 2022
@melix melix added this to the 5.3.13 milestone Jul 21, 2022
@melix melix requested review from timyates and alvarosanchez July 21, 2022 16:23
@melix melix self-assigned this Jul 21, 2022
@melix
Copy link
Contributor Author

melix commented Jul 21, 2022

@timyates I tested this PR against the 3.6.x branch of micronaut core, as well as your OpenAPI PR. Both show breaking changes.

@timyates
Copy link
Contributor

@melix was it the same changes in both? I'll take a look

@melix melix merged commit 04437de into master Jul 22, 2022
@melix melix deleted the cc/check-bom-compat branch July 22, 2022 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: improvement A minor improvement to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants