Fix logback optimization, when appender encoder with charset #313
Conversation
|
@melix Hi! Could you merge all Pr's and finilize new release? Without this fix can't use logback optimizer |
| Method valueOf = parameterType.getDeclaredMethod("valueOf", String.class); | ||
| codeBuilder.addStatement("$L.$L($T.valueOf($S))", parentVarName, method.getName(), ClassName.get(parameterType), model.getBodyText()); | ||
| if (Charset.class.equals(parameterType)) { | ||
| parameterType.getDeclaredMethod("forName", String.class); |
There was a problem hiding this comment.
| parameterType.getDeclaredMethod("forName", String.class); |
Not necessary since the type is fixed.
There was a problem hiding this comment.
@yawkat As you see, you're not right. My first fix was right. LogLevel uses valueOf method, forName needs only for Charset
There was a problem hiding this comment.
If you told me about this line parameterType.getDeclaredMethod("forName", String.class); - you're not right too. You need to set argument type - String.class, otherwise you will see exception message
There was a problem hiding this comment.
@yawkat For a long time I could not understand what you meant. Only now everything became clear. So, I just don't see the code that you see.
Look at the screenshot with the changes
There was a problem hiding this comment.
@yawkat Also, if you are talking about calling a method, then I think that this would be done to get an exception at the optimization stage, i.e. the exception is thrown in the optimizer code. Otherwise, the code will be generated and you will receive an error only at the compilation stage and it will be much more difficult to understand where the error is. So I left the call to this method
altro3
force-pushed
the
fix-logback-appender-charset
branch
3 times, most recently
from
ed40f5b to
38bfc80
Compare
altro3
force-pushed
the
fix-logback-appender-charset
branch
from
38bfc80 to
2f1e7d0
Compare
Fixed #311