Add missing metrics for Jersey in cases of client errors

[adpaste]

We are using Jersey integration and we have noticed that some 40x errors (such as 406 Not Acceptable or 415 Unsupported Media Type) are not reported in the metrics.

After some debugging, we found out that the root cause of this issue is that only one kind of client exception (NotFoundException) is taken into account during metric collection.

This pull request should fix the problem, by taking into account all types of ClientErrorExceptions.

[pivotal-cla]

@adpaste Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

[pivotal-cla]

@adpaste Thank you for signing the Contributor License Agreement!

[shakuzen]

Thanks for reporting the issue and providing a fix along with a test. Could you take a look at the one comment I had and rebase the pull request on 1.9.x so we can accept it as a bug fix? Also, note that the Jersey instrumentation was added to a jersey-micrometer module in the Jersey repo (see eclipse-ee4j/jersey#5391). We plan to deprecate the code in the Micrometer repo in favor of that (see #4100). So please send a pull request over there too if you have the time and consider migrating to using that over what will be deprecated here.

Thanks again!

[adpaste]

Thanks for the feedback. I replied to the comment, and rebased the PR to 1.9.x.
I'll look into migrating to jersey-micrometer.

[shakuzen]

It looks like this broke tests in the 1.11.x branch. I'm looking into it now.
https://app.circleci.com/pipelines/github/micrometer-metrics/micrometer/6107/workflows/6c026dde-bd49-4bb1-a8d7-bdb0f07168b3/jobs/30900

[shakuzen]

I was able to fix it by applying similar changes to JerseyKeyValues (which is a copy of JerseyTags for Observation-based instrumentation). See 66c1d47