Add timestamp (wall time) information on the Event #4034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
I'm not sure I understand the use-case (I made a comment on the issue).
|
|
||
| @Override | ||
| public TimeUnit getTimestampTimeUnit() { | ||
| return TimeUnit.MILLISECONDS; |
There was a problem hiding this comment.
Is this needed? Can we just say in the javadocs that it is the current wall time in ms?
There was a problem hiding this comment.
That's what I did originally. I even named the method getTimestampInMs or sth like that. With 2 methods there is no doubt about what the units are and you are able to modify it as you please. Without that you can make easy mistakes (like I did when I've forgotten that timestamp in Brave is micro not milliseconds 🤷 ). WDYT @shakuzen ?
Co-authored-by: Jonatan Ivanov <[email protected]> Closes gh-4032
jonatan-ivanov
force-pushed
the
timestampedEvent
branch
from
3bad57e to
4f3543b
Compare
|
The things I changed in the PR:
|
jonatan-ivanov
changed the title
izeye
added a commit
to izeye/micrometer
that referenced
this pull request
Sep 25, 2023
shakuzen
pushed a commit
that referenced
this pull request
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes gh-4032