Drop summary and timer lines with a count of 0 in the Dynatrace exporter #2970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -174,6 +174,10 @@ private String createCounterLine(Meter meter, Measurement measurement) { | |||
|
|
|||
| private Stream<String> toSummaryLine(Meter meter, HistogramSnapshot histogramSnapshot, TimeUnit timeUnit) { | |||
| long count = histogramSnapshot.count(); | |||
| if (count < 1) { | |||
There was a problem hiding this comment.
Is there a difference on the backend between sending a zero measurement and not sending a measurement at all?
E.g.: If the service is down (or the meter got removed from Micrometer) vs. it is up but it is not receiving any traffic.
There was a problem hiding this comment.
As far as I am aware, there currently is no difference for summary metrics.
|
I'm not able to rebase this against 1.8.x so I opened a new PR with the rebased commit: #3030 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, Dynatrace metrics lines (summaries and timers) with a count of 0 are dropped on the exporter side.