Rename OneAgentMetadataEnrichment to DynatraceMetadataEnrichment #2692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonatan-ivanov
added
registry: dynatrace
| @@ -71,7 +71,7 @@ public DynatraceExporterV2(DynatraceConfig config, Clock clock, HttpSender httpC | |||
| .withPrefix(config.metricKeyPrefix()) | |||
| .withDefaultDimensions(parseDefaultDimensions(config.defaultDimensions())); | |||
|
|
|||
| if (config.enrichWithOneAgentMetadata()) { | |||
| if (config.enrichWithDynatraceMetadata()) { | |||
There was a problem hiding this comment.
Do you also want to replace this (line#94)?
Potential misconfiguration detected: Token is provided, but the endpoint is set to the local OneAgent endpoint,
| @@ -117,7 +117,7 @@ void testV2Defaults() { | |||
| assertThat(config.uri()).isSameAs(DynatraceMetricApiConstants.getDefaultOneAgentEndpoint()); | |||
| assertThat(config.metricKeyPrefix()).isEmpty(); | |||
| assertThat(config.defaultDimensions()).isEmpty(); | |||
| assertThat(config.enrichWithOneAgentMetadata()).isTrue(); | |||
| assertThat(config.enrichWithDynatraceMetadata()).isTrue(); | |||
There was a problem hiding this comment.
Do you also want to rename testOneAgentEndpointWithDifferentPort?
|
Thanks for taking a look! There are two different features here which happen to have similar names:
|
jonatan-ivanov
approved these changes
Jul 9, 2021
|
@pirgeo Makes sense, thank you for the fix! :) |
This was referenced Jul 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This renames the config property from OneAgent metadata to Dynatrace metadata since the metadata retrieved is not restricted to only the OneAgent but might come from other components in the future.
I will update both spring-projects/spring-boot#26258 and micrometer-metrics/micrometer-docs#160 as soon as this is merged.