Upgrade to Reactor 2020.0 #2588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shakuzen
added
enhancement
shakuzen
commented
Apr 30, 2021
| @@ -66,7 +66,7 @@ void bufferMultipleStrings() { | |||
| "fourteen bytes" | |||
| ); | |||
|
|
|||
| Flux<String> buffered = BufferingFlux.create(source, "\n", 27, Long.MAX_VALUE); | |||
| Flux<String> buffered = BufferingFlux.create(source, "\n", 27, 1000); | |||
There was a problem hiding this comment.
shakuzen
commented
Apr 30, 2021
| @@ -79,8 +80,7 @@ | |||
| private final HierarchicalNameMapper nameMapper; | |||
| private final Map<Meter.Id, StatsdPollable> pollableMeters = new ConcurrentHashMap<>(); | |||
| private final AtomicBoolean started = new AtomicBoolean(); | |||
| DirectProcessor<String> processor = DirectProcessor.create(); | |||
| FluxSink<String> fluxSink = new NoopFluxSink(); | |||
| Sinks.Many<String> sink = new NoopManySink(); | |||
There was a problem hiding this comment.
As I was working on this, I wished there was a built-in no-op implementation, but then I wondered if we really need one. If we don't subscribe, then it is almost a no-op. Maybe our NoopManySink isn't really needed?
There was a problem hiding this comment.
Let's explore this in a separate change.
shakuzen
commented
May 12, 2021
...ry-statsd/src/main/java/io/micrometer/statsd/internal/LogbackMetricsSuppressingManySink.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-attempts #2359. This is using the
tryEmitNextmethod instead ofemitNextto avoid any failure handling - we want to drop elements on failure.This implementation hopefully obviates #2378.
Opened as a draft until we branch 1.7.x somainis ready for 1.8 development.This will make the implementation of #792 straightforward since Reactor Netty added support for UDS in 1.0.0.