More accurate metrics for 404 responses from Jersey #2587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…of the matched resource and only use the "not_found" value if no resource was matched
|
@bentmann Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@bentmann Thank you for signing the Contributor License Agreement! |
shakuzen
added
the
module: micrometer-jersey
shakuzen
approved these changes
Oct 14, 2021
shakuzen
changed the title
shakuzen
added a commit
that referenced
this pull request
Oct 14, 2021
The enhancement was made against the now deprecated micrometer-jersey2 module. This ports the changes and test over to the duplicated code in micrometer-core. See gh-2587
|
Ported to micrometer-core in def88d1 |
shakuzen
added
the
module: micrometer-core
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm aware of the issue of tag explosion that motivates the mapping of 404 responses to a single URI such as "not_found". However, there are two distinct cases where the JAX-RS response can be 404:
I argue only the first case applies to the tag explosion concern. The second case however is not different than matched resources yielding HTTP 400.
With the proposed change, the HTTP 404 responses emitted by Jersey apps can be more appropriately attributed to the originating resource.