Add dynatrace meter registry for metrics api v2 #2406
Conversation
…r meter line function
…for metric dimensions
…ingConvention Tests
| default String entityId() { return getString(this,"entityId").orElse(""); } | ||
|
|
||
| default String apiToken() { | ||
| if (this.uri().contains("localhost")) { |
There was a problem hiding this comment.
This is always required for V1, did V1 mandate auth while V2 does not?
| import java.util.stream.Stream; | ||
| import java.util.stream.StreamSupport; | ||
|
|
||
| class Streams { |
There was a problem hiding this comment.
Why is this needed, would not calling StreamSupport.stream be ok (the rest of the codebase does that)?
I think if we can agree that dropping the parallel parameter has some value that worth the change, we can do it everywhere but I would do it in a separate PR.
|
|
||
| @SpringBootApplication(scanBasePackageClasses = PersonController.class) | ||
| @EnableScheduling | ||
| public class Dynatrace2Sample { |
There was a problem hiding this comment.
Since Spring Boot does not support it, this won't work. I would create the DynatraceMeterRegistry @Bean here.
| # limitations under the License. | ||
| # | ||
|
|
||
| management.metrics.export.dynatrace2: |
There was a problem hiding this comment.
How about the deviceName?
| addCommonTags_groupName(); | ||
| } | ||
|
|
||
| private void addCommonTags_groupName() { |
There was a problem hiding this comment.
Could you please do camelCase?
| @Override | ||
| protected void publish() { | ||
| NamingConvention lineProtocolNamingConvention = config().namingConvention(); | ||
| MetricLineFactory metricLineFactory = new MetricLineFactory(clock, lineProtocolNamingConvention); |
There was a problem hiding this comment.
Why do we need a new instance every time?
| List<String> metricLinesToSkip = metricLines.get(true); | ||
| if (!metricLinesToSkip.isEmpty()) { | ||
| logger.warn( | ||
| "Dropping {} metric lines because are greater than line protocol max length limit ({}).", |
There was a problem hiding this comment.
Are you sure this limit still exist? I did not see it in the docs.
| */ | ||
| class LineProtocolFormatters { | ||
|
|
||
| private static final DecimalFormat METRIC_VALUE_FORMAT = new DecimalFormat( |
There was a problem hiding this comment.
DecimalFormat is not thread-safe, can it be used by multiple thread?
|
Closing in favor of #2581 |
Fix #2295 - Adding new implementation (dynatrace2) to make use of Dynatrace Metrics API v2