Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Time method calls within a class when class is annotated with @Timed #1279

Merged
merged 1 commit into from
Mar 17, 2022
Merged

Time method calls within a class when class is annotated with @Timed #1279

merged 1 commit into from
Mar 17, 2022

Conversation

sabouri
Copy link
Contributor

@sabouri sabouri commented Mar 12, 2019 •
edited by shakuzen
Loading

Assuming that when a class is annotated @timed, the expected behavior is to measure all methods of the class, this PR adds an advice to perform just that.

Resolves #493

@sabouri sabouri mentioned this pull request Mar 12, 2019
Closed
@sabouri sabouri force-pushed the 1278 branch 2 times, most recently from 85af7f2 to d59e86c Compare March 12, 2019 13:13
@berngp berngp mentioned this pull request Sep 11, 2019
Closed
@themistoklik
Copy link

any news/updates if this is going to be merged?

@makowskimateusz
Copy link

@shakuzen @izeye What do you think about it? Are you planning to pull-in this? Would be super useful for me and not only for me probably :)

@MaxZhuravsky
Copy link

any update on this one?

@makobernal
Copy link

Hello all. Is there any chance this PR can make it into the branch? I find it extremely useful, and it's much less confusing to make @Timed apply to classes as well, instead of methods only.

@shakuzen shakuzen changed the title #1278 Add metrics to all method calls withing a class when class is annotated with @Timed Time method calls within a class when class is annotated with @Timed Mar 4, 2022
@pivotal-cla
Copy link

@sabouri Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@shakuzen shakuzen changed the base branch from main to 1.9.x March 4, 2022 10:08
shakuzen
shakuzen approved these changes Mar 4, 2022
View reviewed changes
Copy link
Member

@shakuzen shakuzen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks @sabouri. Would you be willing to sign the CLA so we can accept your contribution?

@shakuzen shakuzen added waiting for feedback We need additional information before we can continue blocked An issue that's blocked on an external project change labels Mar 16, 2022
@pivotal-cla
Copy link

@sabouri Thank you for signing the Contributor License Agreement!

@shakuzen shakuzen removed waiting for feedback We need additional information before we can continue blocked An issue that's blocked on an external project change labels Mar 17, 2022
@shakuzen shakuzen linked an issue Mar 17, 2022 that may be closed by this pull request
Be able to target classes and not only methods with TimedAspect #493
Closed
@shakuzen shakuzen merged commit 6081021 into micrometer-metrics:1.9.x Mar 17, 2022
@aleksey-astashenko-jemmic aleksey-astashenko-jemmic mentioned this pull request May 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shakuzen shakuzen shakuzen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Be able to target classes and not only methods with TimedAspect
7 participants
@sabouri @themistoklik @makowskimateusz @MaxZhuravsky @makobernal @pivotal-cla @shakuzen