Refactoring in ContextContainer and implementation #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename SimpleContextContainer to DefaultContextContainer. Drop ContextAccessorLoader and ThreadLocalAccessorLoader in favor of configuring instances of those directly on DefaultContextContainer. The layers above (e.g. Web Framework, GraphQL transport, etc.) have the responsibility to know what accessors should be used, and therefore ContextContainer should be directly configurable. In other words it cannot be a global mechanism like ServiceLoader.
If a ContextContainerPropagator isn't found, it should be an IllegalStateException. It means we don't know how to save to a specific external context, and something is wrong. Or otherwise it would silently not propagate. If a ContextContainer isn't present, there are several cases. - the code expects a ContextContainer and therefore needs to check through the isNoop() method anyway to protect itself, but it might forget to do so. - the code expects there may or may not be a ContextContainer, but wants to start a new one if not found. Here it also needs to check isNoop(), but if it doesn't do so, it could even lead to errors in code that expects an actual ContextContainer and not a noop. - only code that expects there may or may not be a ContextContainer and doesn't care either way benefits; arguably though a noop lurking always has the potential of causing side effects and surprises. For ContextContainerPropagator, we now always throw IllegalStateException if there isn't a compatible one registered. For ContextContainer, restoreFrom raises ISE while separately there is a restoreIfPresentFrom that returns null if not found.
Ordering of methods in DefaultContextContainer consistent with the order in ContextContainer. Rename ContextContainerPropagator to ContextContainerAdapter.
marcingrzejszczak
approved these changes
Jun 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit messages for details:
SimpleContextContainertoDefaultContextContainerand make it publicContextAccessorLoaderandThreadLocalAccessorLoaderin favor of configuring instances of those directly onDefaultContextContainerIllegalStateExceptionwhile also provide explicit method to restore or return null.ContextContainerPropagatortoContextContainerAdapter.