Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump re2 to fix gyp compilation on arm32 #681

Merged
merged 1 commit into from
Dec 20, 2023

Conversation

LaurentGoderre
Copy link
Contributor

No description provided.

@LaurentGoderre
Copy link
Contributor Author

LaurentGoderre commented Dec 20, 2023

As an example here is how this is demonstrated

This breaks

docker run --rm -it node:18-alpine sh
apk add --no-cache --virtual .gyp git python3 linux-headers make g++ > /dev/null
git clone https://github.com/uhop/node-re2.git && cd node-re2/
git checkout 1.20.3
git submodule init && git submodule update
npm install
CXX(target) Release/obj.target/re2/vendor/abseil-cpp/absl/base/internal/cycleclock.o
  CXX(target) Release/obj.target/re2/vendor/abseil-cpp/absl/base/internal/low_level_alloc.o
In file included from ../vendor/abseil-cpp/absl/base/internal/low_level_alloc.cc:26:
../vendor/abseil-cpp/absl/base/internal/direct_mmap.h:75:25: error: 'off64_t' has not been declared
   75 |                         off64_t offset) noexcept {
      |                         ^~~~~~~
make: *** [re2.target.mk:230: Release/obj.target/re2/vendor/abseil-cpp/absl/base/internal/low_level_alloc.o] Error 1
make: Leaving directory '/node-re2/build'
gyp ERR! build error 
gyp ERR! stack Error: `make` failed with exit code: 2
gyp ERR! stack     at ChildProcess.onExit (/node-re2/node_modules/node-gyp/lib/build.js:203:23)
gyp ERR! stack     at ChildProcess.emit (node:events:517:28)
gyp ERR! stack     at ChildProcess._handle.onexit (node:internal/child_process:292:12)
gyp ERR! System Linux 6.4.16-linuxkit
gyp ERR! command "/usr/local/bin/node" "/node-re2/node_modules/.bin/node-gyp" "rebuild"

But this works

docker run --rm -it node:18-alpine sh
apk add --no-cache --virtual .gyp git python3 linux-headers make g++ > /dev/null
git clone https://github.com/uhop/node-re2.git && cd node-re2/
git checkout 1.20.6
git submodule init && git submodule update
npm install

@LaurentGoderre
Copy link
Contributor Author

See docker-library/ghost#400 (comment) for more detail

@Kikobeats
Copy link
Member

Thanks a lot

@Kikobeats Kikobeats merged commit 2c14499 into microlinkhq:master Dec 20, 2023
54 checks passed
@LaurentGoderre LaurentGoderre deleted the fix-re2-arm32 branch December 21, 2023 12:54
daniellockyer pushed a commit to TryGhost/Ghost that referenced this pull request Apr 16, 2024
Installing on arm32 (and perhaps arm64) on Alpine Linux architecture
fails due to re2 a dependency of metascraper.

References:
microlinkhq/metascraper#681
docker-library/ghost#400
cmraible pushed a commit to cmraible/Ghost that referenced this pull request Apr 25, 2024
…host#19401)

Installing on arm32 (and perhaps arm64) on Alpine Linux architecture
fails due to re2 a dependency of metascraper.

References:
microlinkhq/metascraper#681
docker-library/ghost#400
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants