perf(errors): avoid parse error twice (#592)

microlinkhq · Sep 12, 2024 · 6e3fb40 · 6e3fb40
1 parent 7b80314
commit 6e3fb40
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 2 deletions.
diff --git a/packages/errors/index.js b/packages/errors/index.js
@@ -4,9 +4,22 @@ const debug = require('debug-logfmt')('browserless:error')
 const { serializeError } = require('serialize-error')
 const whoops = require('whoops')
 
-const ERROR_NAME = 'BrowserlessError'
+const createErrorFactory = opts => whoops('BrowserlessError', opts)
 
-const createBrowserlessError = opts => whoops(ERROR_NAME, opts)
+const markAsProcessed = error => {
+  Object.defineProperty(error, '__parsed', {
+    value: true,
+    writable: false,
+    enumerable: false,
+    configurable: false
+  })
+  return error
+}
+
+const createBrowserlessError = opts => {
+  const createError = createErrorFactory(opts)
+  return (...args) => markAsProcessed(createError(...args))
+}
 
 const browserlessError = {}
 
@@ -28,9 +41,12 @@ browserlessError.contextDisconnected = createBrowserlessError({
 })
 
 browserlessError.ensureError = rawError => {
+  if (rawError.__parsed) return rawError
+
   debug('ensureError', serializeError(rawError))
 
   const error = 'error' in rawError ? rawError.error : rawError
+
   const { message: errorMessage = '' } = error
 
   if (

diff --git a/packages/errors/test/index.js b/packages/errors/test/index.js
@@ -3,6 +3,13 @@
 const test = require('ava')
 const errors = require('..')
 
+test('avoid parse ensureError twice', t => {
+  const error = errors.ensureError({
+    message: 'Protocol error (Runtime.callFunctionOn): Target closed.'
+  })
+  t.true(error.__parsed)
+})
+
 test('protocolError', t => {
   const parsedError = errors.ensureError({
     message: 'Protocol error (Runtime.callFunctionOn): Target closed.'