Fix invalid property class name parsing #250
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
nestedMfPropertyNamesFromClass
method was parsing property classes regardless if they were valid (e.g.p-4
). Updated the method to use existingmfNamesFromClass
method, which uses the correct regex to skip those classes.Also fixed a test for
nestedMfPropertyNamesFromClass
which asserted the response array was equal. The expected and actual response array had the same values, but in different order. The order is not important in that response, so I switched the assertion toassertEqualsCanonicalizing
.This also appeared to fix #246, so I added a test to confirm that.
Fixes #249
Fixes #246