-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix vevent location backcompat #201
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issue here
According to the original issue #184 this tries to address two tests:
|
The Travis failure now is on PHP 5.5 with masterminds/html5. Once #220 is resolved I can rebase on master and that should be good to go. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The updated functional edits LGTM.
Nit: were the indentation/whitespace changes in ClassicMicroformatsTest.php really necessary?
I'm not happy about them (so many that GitHub didn't even display them by default and I had to expand the diffs!) but it's also not blocking. I'd prefer if those could be reverted so I'm marking this "Request changes". If there was a good reason to mix that into this commit, please comment accordingly and I'll approve.
The .editorconfig introduced a little bit ago specifies tabs so I think my editor did that automatically. Adding |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have rerun the tests with the new testing in place on master.
composer run phpunit -- --group microformats/tests/mf1
With this PR merged (like before), we are now able to pass the hcalendar/combining test.
But also like before, this still does not fix hcalendar/attendees:
Mf2\Parser\Test\MicroformatsTestSuiteTest::testMf1FromTestSuite with data set "hcalendar/attendees" ('<meta charset="utf-8">\n<div c.../div>\n', '{\n "items": [{\n "ty...: {}\n}', 'hcalendar/attendees')
Failed asserting that two arrays are equal.
--- Expected
+++ Actual
@@ @@
Array (
'items' => Array (
0 => Array (
'properties' => Array (
- 'attendee' => Array (...)
'location' => Array (...)
'name' => Array (...)
'start' => Array (...)
)
'type' => Array (...)
+ 'children' => Array (...)
)
)
'rel-urls' => Array ()
'rels' => Array ()
)
This PR does not introduce any new test breaks, so it looks good to me for merge. But we need to decide whether we want the hcalendar/attendees test to pass or not.
Would be nice to get this branch rebased on master so it is easier to run tests.
Includes whitespace fixes in ClassicMicroformatsTest.php View updates sans whitespace.
Fixes #184