Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete apiはjsonを返さないのでそのように変更 #35

Merged
merged 1 commit into from
Aug 9, 2022

Conversation

dc7290
Copy link
Member

@dc7290 dc7290 commented Aug 9, 2022

概要

DELETE APIにおいて返却される値は空であるところ、response.json()をしてしまっていたので
DELETEの場合は何も返さないように変更しました。

背景

delete関数を実行すると処理自体は完了するが、
node-fetchのInvalid JSONエラーが出る。

変更の種類

fix

@dc7290 dc7290 requested a review from hiro08gh August 9, 2022 01:49
@hiro08gh
Copy link
Contributor

hiro08gh commented Aug 9, 2022

LGTMです!

@dc7290 dc7290 merged commit 73dd3e6 into main Aug 9, 2022
@dc7290 dc7290 deleted the fix-delete-api-response branch August 9, 2022 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants