Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest docker-mui-theme #66

Merged
merged 1 commit into from
Nov 19, 2024
Merged

Update to latest docker-mui-theme #66

merged 1 commit into from
Nov 19, 2024

Conversation

hguerrero
Copy link
Member

Description

  • Update to latest docker-mui-theme
  • Use vite instead of react-scripts

Related issue(s)

Resolves #59

Use vite instead of react-scripts
Signed-off-by: Hugo Guerrero <[email protected]>
@hguerrero hguerrero requested a review from lbroudoux as a code owner November 4, 2024 03:08
@lbroudoux
Copy link
Member

Build seems to fail only because it cannot deduce a container image tag from the branch name.

Copy link
Member

@lbroudoux lbroudoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Shouldn't we update the screenshots of the plugin after the MUI theme update? Or maybe the L&F is kept unchanged?

@lbroudoux lbroudoux added this to the 0.3.2 milestone Nov 18, 2024
@lbroudoux lbroudoux added kind/task dependencies Pull requests that update a dependency file labels Nov 18, 2024
@lbroudoux
Copy link
Member

AFAIK the L&F didn't change.

Copy link
Member

@lbroudoux lbroudoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK the L&F didn't change

@lbroudoux lbroudoux merged commit d80f53f into main Nov 19, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file kind/task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump @docker/docker-mui-theme to 0.0.11
2 participants