Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build process leaves residual temp_target file on file system #292

Open
eecavanna opened this issue Jan 22, 2025 · 1 comment
Open

Build process leaves residual temp_target file on file system #292

eecavanna opened this issue Jan 22, 2025 · 1 comment
Labels
x small less than 1 day

Comments

@eecavanna
Copy link
Contributor

When I follow the build instructions documented in the README.md file, I end up with several modified files, one of which is an empty file named temp_target in the root directory of the repo.

Image

The final line of this make target creates the file:

# Intermediate target that dynamically processes matching TSV files
temp_target: $(WATCHED_FILES) src/nmdc_submission_schema/schema/nmdc_submission_schema.yaml
@echo "Processing all matching TSV files in $(WATCHED_DIR)..."
@for tsv_file in $(WATCHED_FILES); do \
echo "Processing $$tsv_file..."; \
$(RUN) inject-env-triad-terms -f $$tsv_file \
-i src/nmdc_submission_schema/schema/nmdc_submission_schema.yaml \
-o src/nmdc_submission_schema/schema/nmdc_submission_schema.yaml || exit 1; \
done
@touch temp_target

I recommend documenting the process of cleaning up that file; or editing the Makefile or one of the programs it runs, so that that file does not remain in existence after the build process.

@eecavanna eecavanna added the x small less than 1 day label Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
x small less than 1 day
Projects
None yet
Development

No branches or pull requests

2 participants