DNA sample name doesn't allow "." in names, but it should

[mslarae13]

I am not sure if this should be in schema or submission-schema

The slot "DNA sample name" won't validate for a submission, I think, because there's "." in the sample name.
According to the JGI guidance "Give the sample a name that is meaningful to you. Sample names must be unique across all JGI projects and contain ASCII characters only."

Periods "." are ASCII valid. Looking at the regex in the submission portal "Pattern as regular expression: /^[_a-zA-Z0-9-]*$/"

I'm guessing it doesn't allow for "."

To resolve:

• Update the submissions schema regex to allow for . and any ASCII character

[mslarae13]

I have a submitted pending review submission with the "." in the names. Which means something happened / was changed to make these no longer valid.

I don't know what keeps happening to validation or why regular expressions are getting added without my review, but this needs to be addressed.

[mslarae13]

4954e08#r150711705

[mslarae13]

I think I found another valid metadata entry that was made invalid by an unexpected or tested regex being added.

Why are these values invalid? Make a new issue to resolve this one, depending on the discussion and path to resolution for the above issue.

[turbomam]

This is a good catch but i disagree that we should allow "any ASCII character". Maybe any printable ASCII character?

https://en.wikipedia.org/wiki/ASCII#Printable_character_table

[mslarae13]

That decision is JGI's, not ours... And the JGI template says "contain ASCII characters only."
What are the non printable ones? Maybe it's just lack of clarification on JGI? @turbomam

[turbomam]

Strictly speaking, non-printable ASCII characters include things like backspace, carriage return and communications flags like "I acknowledge I got your last message"

In this UNICODE era, whether ASCII or ASCII printable are even relevant character sets for this kind of thing is another question. Maybe JGI is saying that they don't want to include symbols or characters from on-US alphabets like Á, Ø, ß. That's why invalid examples are so important.