Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor code to use metadata endpoints #8

Closed
hesspnnl opened this issue Jan 8, 2025 · 1 comment · Fixed by #9
Closed

Refactor code to use metadata endpoints #8

hesspnnl opened this issue Jan 8, 2025 · 1 comment · Fixed by #9
Assignees

Comments

@hesspnnl
Copy link
Collaborator

hesspnnl commented Jan 8, 2025

There is no difference between the between the Find enpoints /{collection}/ and Metadata nmdc/{collection_name}. They are reaching into the same data source. Katherine recommends I should only use the nmdc/{collection_name} endpoint and create the mongo filters for the things ie by pi, id, name, etc.
If the user wants to then can pass in more filters.

@hesspnnl hesspnnl self-assigned this Jan 8, 2025
@hesspnnl
Copy link
Collaborator Author

hesspnnl commented Jan 8, 2025

began this change in the biosample class. will bring this to study as well.

@hesspnnl hesspnnl linked a pull request Jan 16, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant