-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
env_package
should have a range of an Enum
#2167
Comments
@mslarae13 @pkalita-lbl please comment on if you are okay with these proposed changes wrt submission portal. This will streamline the nmdc mongo to ncbi xml code. Otherwise we'll need a mapping table. |
I would also be open to the permissible values coming from MIxS Extensions, but am totally happy with @sujaypatil96's suggestion for the values NCBI calls |
We need an official mapping between the NCBI namespace, the MIxS namespace, and any variable used in code like submission-schema and nmdc-server |
Broadly speaking that seems okay. As far as the submission portal is concerned, The submission portal's frontend code already maintains a crazy mapping between human readable names and |
The
env_package
slot in the schema should have the range of an Enum, with the list of permissible values constructed using the value of<EnvPackage>
in https://www.ncbi.nlm.nih.gov/biosample/docs/packages/?format=xml (so we are aligned with NCBI as well)The text was updated successfully, but these errors were encountered: