Skip to content

Commit

Permalink
Merge pull request #39 from microbiome/bugfix
Browse files Browse the repository at this point in the history
Update args of .multiSelectionResponsive
  • Loading branch information
RiboRings authored Dec 14, 2024
2 parents 250f5fd + 1b7e26c commit 23ce730
Show file tree
Hide file tree
Showing 10 changed files with 25 additions and 17 deletions.
2 changes: 1 addition & 1 deletion DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
Package: iSEEtree
Version: 1.1.0
Version: 1.2.0
Authors@R:
c(person(given = "Giulio", family = "Benedetti", role = c("aut", "cre"),
email = "[email protected]",
Expand Down
4 changes: 4 additions & 0 deletions NEWS
Original file line number Diff line number Diff line change
Expand Up @@ -17,3 +17,7 @@ Changes in version 0.99.3

Changes in version 0.99.8
* Added ColumnTreePlot and LoadingPlot panels

Changes in version 1.2.0
* Updated .multiSelectionResponsive
* Conformed to iSEE v2.19.2
7 changes: 4 additions & 3 deletions R/class-AbundanceDensityPlot.R
Original file line number Diff line number Diff line change
Expand Up @@ -269,12 +269,13 @@ setMethod(".hideInterface", "AbundanceDensityPlot", function(x, field) {
})

setMethod(".multiSelectionResponsive", "AbundanceDensityPlot",
function(x, dims = character(0)) {
function(x, dim = character(0)) {

if ("row" %in% dims) {
if ("row" %in% dim) {
return(TRUE)
}
return(FALSE)

return(FALSE)
})

#' @importFrom methods callNextMethod
Expand Down
4 changes: 2 additions & 2 deletions R/class-AbundancePlot.R
Original file line number Diff line number Diff line change
Expand Up @@ -237,9 +237,9 @@ setMethod(".hideInterface", "AbundancePlot", function(x, field) {
})

setMethod(".multiSelectionResponsive", "AbundancePlot",
function(x, dims = character(0)) {
function(x, dim = character(0)) {

if( "column" %in% dims ){
if( "column" %in% dim ){
return(TRUE)
}
return(FALSE)
Expand Down
4 changes: 2 additions & 2 deletions R/class-ColumnTreePlot.R
Original file line number Diff line number Diff line change
Expand Up @@ -265,9 +265,9 @@ setMethod(".hideInterface", "ColumnTreePlot", function(x, field) {
})

setMethod(".multiSelectionResponsive", "ColumnTreePlot",
function(x, dims = character(0)) {
function(x, dim = character(0)) {

if( "column" %in% dims ){
if( "column" %in% dim ){
return(TRUE)
}

Expand Down
7 changes: 4 additions & 3 deletions R/class-LoadingPlot.R
Original file line number Diff line number Diff line change
Expand Up @@ -239,12 +239,13 @@ setMethod(".hideInterface", "LoadingPlot", function(x, field) {
})

setMethod(".multiSelectionResponsive", "LoadingPlot",
function(x, dims = character(0)) {
function(x, dim = character(0)) {

if ("row" %in% dims) {
if ("row" %in% dim) {
return(TRUE)
}
return(FALSE)

return(FALSE)
})

#' @importFrom methods callNextMethod
Expand Down
4 changes: 2 additions & 2 deletions R/class-RDAPlot.R
Original file line number Diff line number Diff line change
Expand Up @@ -296,9 +296,9 @@ setMethod(".hideInterface", "RDAPlot", function(x, field) {
}
})

setMethod(".multiSelectionResponsive", "RDAPlot", function(x, dims = character(0)) {
setMethod(".multiSelectionResponsive", "RDAPlot", function(x, dim = character(0)) {

if( "column" %in% dims ){
if( "column" %in% dim ){
return(TRUE)
}
return(FALSE)
Expand Down
4 changes: 2 additions & 2 deletions R/class-RowTreePlot.R
Original file line number Diff line number Diff line change
Expand Up @@ -265,9 +265,9 @@ setMethod(".hideInterface", "RowTreePlot", function(x, field) {
})

setMethod(".multiSelectionResponsive", "RowTreePlot",
function(x, dims = character(0)) {
function(x, dim = character(0)) {

if( "row" %in% dims ){
if( "row" %in% dim ){
return(TRUE)
}

Expand Down
6 changes: 4 additions & 2 deletions vignettes/iSEEtree.Rmd
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,8 @@ SCREENSHOT("screenshots/get_started.png", delay=20)

## Citation

We hope that iSEEtree will be useful for your research. Please use the following information to cite the package and the overall approach. Thank you!
We hope that iSEEtree will be useful for your research. Please use the following
information to cite the package and the overall approach. Thank you!

```{r citation}
## Citation info
Expand All @@ -176,7 +177,8 @@ citation("iSEEtree")

## Background Knowledge

iSEEtree is based on many other packages and in particular on those that have implemented the infrastructure needed for dealing with omics data, microbiome
iSEEtree is based on many other packages and in particular on those that have
implemented the infrastructure needed for dealing with omics data, microbiome
data and interactive visualisation. That is, packages like
[_SummarizedExperiment_](https://bioconductor.org/packages/3.18/bioc/html/SummarizedExperiment.html),
[_TreeSummarizedExperiment_](https://bioconductor.org/packages/3.18/bioc/html/TreeSummarizedExperiment.html),
Expand Down
Binary file modified vignettes/screenshots/get_started.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.

0 comments on commit 23ce730

Please sign in to comment.