Fix non-durable consumer groups #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jkoberg <[email protected]>
kobergj
force-pushed
the
FixNatsjsDurableConsumers
branch
from
75d2bdf to
8eddd66
Compare
2403905
approved these changes
Dec 14, 2023
|
Force merging this as approve is sufficient |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Non-Durable consumer groups (aka ephemeral consumers) could not be create as a
QueueSubscribecall would always create a durable consumer group. We now callSubscribeinstead if there is a non durable group requested.Also fixes linter warning for the events/natsjs package so green pipelines are possible again.
Also tweaks
.golangci.ymlminimally by fixing depguard syntax and disablingforbidigoanderrcheckfor_test.gofiles.