Add custom album art size

[kjk2010]

This PR adds a new API method for requesting custom album art image sizes in JPEG format. This method is used by the keypad controllers I have been developing, but could also be used for other clients.

It currently only supports local input and Internet Radio album art. I've been unsuccessful in using Pandora on my dev Pi 2, and the current Spotify client doesn't appear to include any metadata or album art information.

The included rca_inputs.jpg file is converted from the original SVG file. This was done because the 'pillow' library doesn't support converting from SVG.

[codecov-commenter]

Codecov Report

Merging #121 (bf294e4) into master (ea7d2e2) will increase coverage by 0.13%.
The diff coverage is 60.39%.

@@            Coverage Diff             @@
##           master     #121      +/-   ##
==========================================
+ Coverage   59.57%   59.70%   +0.13%     
==========================================
  Files          11       11              
  Lines        2031     2065      +34     
==========================================
+ Hits         1210     1233      +23     
- Misses        821      832      +11     

Flag	Coverage Δ
unittests	59.70% <60.39%> (+0.13%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
amplipi/streams.py	48.45% <42.85%> (-0.11%)	⬇️
amplipi/app.py	84.66% <60.00%> (-2.84%)	⬇️
amplipi/ctrl.py	77.82% <100.00%> (+0.24%)	⬆️
amplipi/models.py	93.75% <100.00%> (+0.25%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea7d2e2...bf294e4. Read the comment docs.

[linknum23]

I really like how simple this addition looks, nice work!

I will spend more time checking this out after merging in #116, since that PR is a little bit of a tear-up for the flask infrastructure. (There will need to be a couple of minor changes to the API plumbing once that is merged, I can make those to make this easier to merge)

I can also adding Pandora image conversion, we use that a lot over here.

In the meantime I'm trying to think of the best way to add a simple automated test for this addition to the API, do you have any ideas?

[kjk2010]

For tests, I'm thinking a GET request on /api/streams/image/0/120 (should be the rca_local.jpg binary image, Content-Type: image/jpg) and /api/streams/image/{validStreamId}/120 (should be a stream's binary image, also Content-Type: image/jpg).

Thanks!

[linknum23]

I started working on integrating this in, but got pulled in a couple of different ways and have not been able to finish up testing this.

What I got stuck on was how the analog inputs are handled on what is essentially a stream input and this seemed like something that might break in future changes. I know we had discussed how to handle this in the past but I was not able to find the discussion. Did the discussion get deleted?

[kjk2010]

There was some additional discussion of this feature on the POE Keypad discussion: #77 (comment)

I'd like for the analog input images to eventually be custom configured so users can upload their own images for different inputs, and possibly even be set to call an external API in the event that the analog source device can provide the metadata and/or album art.

In the mean time, I was just having this PR send the rca_inputs.jpg file for analog inputs.

[linknum23]

I have a protoype of this working in my branch. Mind if I force push it into your branch? I could also make a separate PR if that makes more sense.

[linknum23]

Ooops, looks like i forced pushed to the wrong origin, sorry about that.

I changed the endpoint to be /api/sources/{sid}/image/{height} and made sources hold the metadata of what is currently playing in them.

I know this adds a couple of changes on your side, so I will try to make the changes to the touchscreen code tomorrow and see how it all works together before merging this is. Best case we both get to merge PRs tomorrow.

Feel free to check it out and see if there are any changes you think make sense.

[kjk2010]

Sounds great to me, thanks!

…

On Wed, Jul 7, 2021, 1:11 PM Lincoln Lorenz ***@***.***> wrote: I have a protoype of this working in my branch <https://github.com/micro-nova/AmpliPi/tree/add_custom_albumart_size>. Mind if I force push it into your branch? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#121 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AKNOZ25I7JEAWNUB2GQBGUTTWSYFLANCNFSM45LFBLFQ> .

[micronova-jb]

Everything looks great! Once I get answers to my comments specifically, I am good to approve the changes.

[Lohrer]

We'll definitely have to update the display once the 'state' is fixed.

[linknum23]

This is looking good to go! Album art should work now for any source configuration.

[kjk2010]

This is fantastic! I will test this as soon as I have a chance. Thank you!

…

On Tue, Jul 13, 2021 at 7:46 AM Lincoln Lorenz ***@***.***> wrote: This is looking good to go! Album art should work now for any source configuration. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#121 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AKNOZ2Z7CA4W2T5IGSDRC53TXRGTBANCNFSM45LFBLFQ> .

-- KJ Koning Shout! Radio Services http://www.shoutservices.com