Fix GCC and Clang warnings in MMDevice, MMCore #417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Doesn't change anything but produces warnings from GCC and Clang. This change should not affect the device binary interface.
There is no way to suppress just for exception specifications, but limit the suppression to within the headers. Also make suppression of MSVC C4290 consistent with GCC.
The warnings for dynamic exception specifications are now suppressed in the code using pragmas for both GCC and MSVC.
marktsuchida
force-pushed
the
mmdevice-mmcore-warnings
branch
from
982a5cd to
97ecc51
Compare
And don't manually manage memory to begin with; use std::vector.
marktsuchida
force-pushed
the
mmdevice-mmcore-warnings
branch
from
8a1d3f8 to
d5a58b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far removes warnings on macOS/Clang. Keeping as draft until I add commits for Linux/GCC.