Fix Association between Nodes and EssenceNodes (AlchemyCMS#1826)

There was a typo here resulting in Nodes being associated to themselves in an impossible way.
mickenorlen · May 13, 2020 · 729cd21 · 729cd21
1 parent 0eec65a
commit 729cd21
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/app/models/alchemy/node.rb b/app/models/alchemy/node.rb
@@ -12,7 +12,7 @@ class Node < BaseRecord
 
     has_one :site, through: :language
 
-    has_many :essence_nodes, class_name: "Alchemy::Node", inverse_of: :node
+    has_many :essence_nodes, class_name: "Alchemy::EssenceNode", foreign_key: :node_id, inverse_of: :ingredient_association
 
     validates :name, presence: true, if: -> { page.nil? }
     validates :url, format: { with: VALID_URL_REGEX }, unless: -> { url.nil? }

diff --git a/spec/models/alchemy/node_spec.rb b/spec/models/alchemy/node_spec.rb
@@ -4,6 +4,8 @@
 
 module Alchemy
   describe Node do
+    it { is_expected.to have_many(:essence_nodes) }
+
     it "is only valid with language and name given" do
       expect(Node.new).to be_invalid
       expect(build(:alchemy_node)).to be_valid