Made it work with queries returning multiple elements, also it's possible to run box fit for the same element again (so you can update the text) #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 this PR fixes the issues I was seeing, this library does exactly what I wanted now :) Thank you (both)! |
|
+1 I found the same issue, and fix the same. Running on multiple elements is a plus. |
|
+1 I actually came here to fork this plugin and add this functionality myself - luckily I noticed it's already been added here! |
michikono
added a commit
that referenced
this pull request
Aug 23, 2014
Made it work with queries returning multiple elements, also it's possible to run box fit for the same element again (so you can update the text)
|
This has been accepted and I have subsequently significantly updated the documentation and demo pages. |
|
Seen that, great work! Good to see you dont let this plugin die, thank you @michikono! |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.