use binary searching algorithm if max font value set #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
We have this project in which we're using infinity scrolling with your boxfit plugin. I noticed that for a large number of components which are using this solution, it is noticeably for a user that text is blinking. I also noticed that for searching proper font size, for each element, I need to make ~25 loop steps. So the idea was to use some searching algorithm to reduce number of steps and comparisons. For that I used the binary searching algorithm, whereby the number of steps decreased to ~3. The only requirement is to have both, minimum and maximum font size set.
In pull request I depend my algorithm to settings.maximum_font_size, so it will run only for user who have set that value and for another situations, the old algorithm will be used. If you like my solution, I think we can go on. Maybe there is a possibility to set some default number for maximum_font_size, so it can always use binary algorithm.
Would be nice to know your opinion,
Greetings,
Rafal