Add context to templates / respect slice timeout (apache#4673)

* added context to templates to be able to use filters in SQL * respect slice timeout in favor of others * added trailing comma
michellethomas · May 23, 2018 · 8e7491d · 8e7491d
1 parent c6d635b
commit 8e7491d
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/superset/connectors/sqla/models.py b/superset/connectors/sqla/models.py
@@ -477,6 +477,9 @@ def get_sqla_query(  # sqla
             'metrics': metrics,
             'row_limit': row_limit,
             'to_dttm': to_dttm,
+            'filter': filter,
+            'columns': {col.column_name: col for col in self.columns},
+
         }
         template_processor = self.get_template_processor(**template_kwargs)
         db_engine_spec = self.database.db_engine_spec

diff --git a/superset/viz.py b/superset/viz.py
@@ -279,6 +279,8 @@ def query_obj(self):
 
     @property
     def cache_timeout(self):
+        if self.form_data.get('cache_timeout'):
+            return int(self.form_data.get('cache_timeout'))
         if self.datasource.cache_timeout:
             return self.datasource.cache_timeout
         if (