-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BioSimSpace and OpenForcefieldTK interoperability #117
Comments
Hi @jmichel80, thanks for putting this together. With regards to your question:
In BioSimSpace you can directly upconvert any Sire wrapped object. This means that you can go from a In BioSimSpace/Sire, the only additional property (at least the one we use) of a |
pinging @davidlmobley and @jchodera to keep them in the loop Sorry for the delay -- OFF is somewhat shorthanded right now and I had to help with some science work this month. I've been thinking about this for a while, and it is probably best to talk about which information we hold in which objects. OFF object overviewIn terms of major classes, the OpenFF Toolkit uses OFF OFF OFF OFF OFF MoleculesAn OFF OFF So, one big potential difference between BSS and OFF It would be good to get more clarification on whether BSS Also, OFF OFF TopologiesAn OFF Figuring out which converters to makeUsing the functionality in the OFFTK, it's a one-way road from OFF Given my current understanding, I'd advocate making the following converters:
My logic is that most of the functionality in the OFFTK is centered around assigning parameters. So, someone making a workflow in BSS and looking to integrate OFFTK is probably looking to take a BSS I could use your input on whether OFFMol --> BSSMol conversion would be a popular use case, knowing that OFFMols don't have parameters assigned. Alternatively, we could wait until the OFF |
Hi @j-wags For your question on whether parameters have to be attached to molecules in BSS that's not a strict requirement because BSS Molecules wraps around Sire Molecule objects which can be very flexible in terms of what they contain (could lack coordinates etc...). This just stops you from doing certain things like computing a potential energy etc...Maybe @lohedges can chime in on possible restrictions I may have overlooked. |
Hi all. Apologies for the slow reply too. I think @j-wags post appeared when I was on holiday and I had forgotten to check back in afterwards. As @jmichel80 says, BSS molecules are very flexible since they are simply wrappers around Sire objects. These contain properties, such as
Not necessarily. In BioSimSpace, a Molecule will typically first be generated by reading an input file. If this is just a PDB or Mol2 file then the molecules in the system will not have parameters. You could then use the
No, it's not a requirement. As mentioned above, you can load a unparameterised molecule from file then use BioSimSpace to parameterise it, or read in pre-parameterised molecules from, e.g. AMBER prm/rst files. |
Closing since discussion has moved to this thread. |
Hi,
I am starting a thread to discuss efficient solutions to reliably exchange information back and forth between the OpenFFtoolkit and BioSimSpace libraries.
The purpose would be to facilitate development of code that makes use of functionality available in both toolkits.
We ran an exploratory coding session in August 2019 at the ACS San Diego meeting, the results of which can be found here
What came out of this was that it could be desirable to add functionality in BioSimSpace to enable conversion of a BioSimSpace system into an OpenMM system, and to add functionality in OpenFFto enable conversion of an OpenMM system into a BioSimSpace system. This may well be easier and extensible than a solution that relies on writing/reading with high reliability to fileformats supported by both toolkits. Particularly as we may want to move towards supporting functionality that is not covered by all legacy file formats (e.g. virtual sites, new functional forms for potential energy functions).
Before any significant work is undertaken it would be good to collect opinions about the best way forward.
One immediate question I have is whether the conversion should operate at the level of a ‘system’, a ‘molecule’ or a collection of molecules. Both toolkits seem to have slightly different definition of what this means so I would be good if @lohedges , @j-wags, @ppxasjsm and @chryswoods could comment on this.
The text was updated successfully, but these errors were encountered: