Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Crash when caching config #73

Merged
merged 3 commits into from
Sep 9, 2024

Conversation

neznaika0
Copy link
Contributor

See codeigniter4/CodeIgniter4#9181

It is not recommended to use config('Paths') Configuration caching will stop working.
This applies to all configurations that do not extend BaseConfig.

@neznaika0
Copy link
Contributor Author

We hurried 😄

Copy link
Owner

@michalsn michalsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch. Thank you!

This package was created before the config caching was introduced and I missed that this feature may cause problems here.

src/Config/Services.php Outdated Show resolved Hide resolved
src/Config/Services.php Outdated Show resolved Hide resolved
tests/CommonTest.php Outdated Show resolved Hide resolved
src/Config/Services.php Show resolved Hide resolved
@michalsn michalsn merged commit f3a37ac into michalsn:develop Sep 9, 2024
14 checks passed
@neznaika0 neznaika0 deleted the fix-cache-crash branch October 5, 2024 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants