Migrate CI to GitHub Actions, adding recommended Elixir and Erlang/OTP combinations #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd Erlang/OTP combinations
|
This looks awesome! Thank you ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request migrate the CI from Travis CI to GitHub Actions, as requested by José Valim in this comment.
In addition, it makes sure all recommended Elixir and Erlang/OTP combinations are run on CI.
Quoting José Valim:
Please refer to the original discussion on dashbitco/broadway#188 for the full rationale.
Additional functionality: make sure there are no compilation warnings.
In case one wonders why not use
otp: N.xfor OTP as well as for Elixir, the reason is the following: actions/setup-elixir v1.4.0 uses semantic version resolution for Erlang/OTP, but Erlang/OTP version scheme does not follow SemVer and "In general, versions can have more than three parts.", sootp: 19.xresolves to 19.3.6, not 19.3.6.13, as expected.