Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove RCT-Folly version hardcoding #289

Merged
merged 1 commit into from
Jan 4, 2024

Conversation

hsjoberg
Copy link
Contributor

@hsjoberg hsjoberg commented Dec 10, 2023

Hey. Installing pods currently fails when using react-native 0.73.0 and new architecture.
This is due to version conflict with Folly. react-native-geolocation hardcodes usage of 2021.07.22.00.
Presumably there is no reason for this, so this PR removes that.

[!] CocoaPods could not find compatible versions for pod "RCT-Folly":
  In Podfile:
    RCT-Folly (from `../node_modules/react-native/third-party-podspecs/RCT-Folly.podspec`)

    React-RCTAppDelegate (from `../node_modules/react-native/Libraries/AppDelegate`) was resolved to 0.73.0, which depends on
      RCT-Folly

    ReactCommon/turbomodule/core (from `../node_modules/react-native/ReactCommon`) was resolved to 0.73.0, which depends on
      RCT-Folly (= 2022.05.16.00)

    react-native-geolocation (from `../node_modules/@react-native-community/geolocation`) was resolved to 3.0.6, which depends on
      RCT-Folly (= 2021.07.22.00)

Cheers.

@michalchudziak
Copy link
Owner

Thanks!

@michalchudziak michalchudziak merged commit aa51e7e into michalchudziak:master Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants