Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C4267 conversion from 'size_t' to 'int' #333

Closed
wants to merge 7 commits into from
Closed

C4267 conversion from 'size_t' to 'int' #333

wants to merge 7 commits into from

Conversation

dmex
Copy link

@dmex dmex commented Nov 13, 2024

This PR updates some types to avoid warnings for C4267: conversion from 'size_t' to 'int' when compiling with MSVC

michaelrsweet
michaelrsweet requested changes Nov 14, 2024
View reviewed changes
Copy link
Owner

@michaelrsweet michaelrsweet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No objection to some of the changes, but the public APIs cannot be changed.

mxml-index.c Show resolved Hide resolved
mxml-node.c Show resolved Hide resolved
mxml-node.c Show resolved Hide resolved
mxml.h Show resolved Hide resolved
michaelrsweet added a commit that referenced this pull request Nov 14, 2024
@michaelrsweet
Fix compiler warnings (Issue #333)
5e35d50
@michaelrsweet
Copy link
Owner

Acceptable changes have been pushed, along with a workaround for the reference counting:

[master 5e35d50] Fix compiler warnings (Issue #333)

(unlikely to ever be an issue given the limits of available virtual memory)

@michaelrsweet michaelrsweet self-assigned this Nov 14, 2024
@michaelrsweet michaelrsweet added bug Something isn't working priority-low labels Nov 14, 2024
@michaelrsweet michaelrsweet added this to the Stable milestone Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelrsweet michaelrsweet michaelrsweet requested changes

Assignees

@michaelrsweet michaelrsweet

Labels
bug Something isn't working priority-low
Projects
None yet
Milestone
Stable
Development

Successfully merging this pull request may close these issues.
2 participants
@dmex @michaelrsweet