refs #309, unmarshalling AutoDelete: "undefined"
to false
not true
#312
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
exchange.auto_delete
should not beundefined
-> now defaults tofalse
when it's string"undefined"
, nottrue
.auto_delete
isfalse
undefined
, it's more likely to behave likefalse
Please see the details / origin of this change in #309 .
I could not find any explanation for the changes in #207 .
Why?
Sometimes there are issues with deploying exchanges using topology-operator. Unfortunately, it's a bit hard to reproduce, so I did not find the real problem yet. The exchanges are unchanged, and all set to
auto_delete: false
when being created, but the diff still says thatauto_delete
changed:This is a draft, and I'm not sure how to test this, since I can only un-marshall the JSON, but setting up an exchange with
undefined
would require to "exploit a bug" in rabbitmq. (You shouldn't be able to create an exchange withauto_delete: undefined
in the first place.)If this change leads to problems for lib users, they should fix the original problem -> it may lead to fixes in rabbit? idk.