Add support for user limits #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelklishin
requested changes
Nov 9, 2021
| Ω(err).Should(BeNil()) | ||
| Ω(xs).Should(HaveLen(0)) | ||
| }) | ||
| It("sets the limits", func() { |
There was a problem hiding this comment.
This creates an example inter-dependency (one cannot pass without another being run first). This is not the case with other examples. If it would makes things easier, several examples can be combined.
| @@ -1,7 +1,8 @@ | |||
| ## Changes Between 2.11.0 and 2.12.0 (unreleased) | |||
|
|
|||
| No changes yet. | |||
| Added support to manage user limits. | |||
There was a problem hiding this comment.
This does not follow the formatting convention used in earlier releases. When in doubt, don't touch the change log at all.
michaelklishin
added a commit
that referenced
this pull request
Nov 22, 2021
|
I've addressed the feedback above and merged manually. Thank you for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #216 and adds support for user limits feature which was added in RMQ 3.8.10.
It also adds functions to query vhost and user limits for all vhosts and users respectively.