Refactor FederationDefinition.Uri to []string #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- federation upstream supports multiple uris. See: https://www.rabbitmq.com/federation-reference.html#upstreams. - remove paramToUpstream and use executeAndParseRequest directly; GetRuntimeParameter or ListRuntimeParameter returns uri as interface{} which needs to be converted to []string in a loop
michaelklishin
approved these changes
May 28, 2021
michaelklishin
added a commit
that referenced
this pull request
May 29, 2021
née ShovelURISet, now renamed References #193
This was referenced Jun 2, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #192
paramToUpstreamand useexecuteAndParseRequestdirectly, becauseGetRuntimeParameterorListRuntimeParameterreturns uri asinterface{}which needs to be converted to[]stringin a loop