Added PagedListQueuesWithParameters endpoint + Tests #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks promising, thank you. |
|
Thanks! We're still testing using it in a newrelic integration, but having trouble getting concurrency working, for cases where there are a large number of queues in the cluster. The page feature helped start this, though. |
|
This is the closest we've gotten. May have it working tomorrow. ^^ This works well (commented out) for clusters with a few queues. Our cluster with the most queues (dev, go figure) took 59s to pull...not useful for newrelic infrastructure/insights. |
|
@jordanbcooper are there more changes coming to this PR? I'm not sure how to interpret your last comment, sorry. |
|
No worries, sorry for the confusion. Nothing else to add here |
|
@michaelklishin This is fine to merge. |
michaelklishin
approved these changes
Oct 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So we can loop through "api/queues?page=1".. etc.