-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better typing hints for make_request #447
Better typing hints for make_request #447
Conversation
I can't make the integration test run on my machine, please let me know if I broke any |
@nhruo123 are you able to run
|
My bad, I didn't stage that change. Yea, this is a slight issue as |
to not break lints
This closes #446, there are 2 issues I faced during the development processes that made this PR larger then expected.
ParamSpec
type that was introduced in python 3.10. This forced me to create an untyped version of the function and then two definitions depending on the version of python the user is using. This is not ideal, but I don't see a better solution (beside dropping support for older versions but that's way out of the scope of this PR).mypy
that didn't support the usage ofParamSpec
so I had to bumpmypy
version to 1.0 and above. This introduced some newmypy
errors that I had to fix as well.