Add NATIVE_DECIMALS & LAMPORTS_PER_SOL constants #433
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @n3tn1nja. Thanks for the contribution. Would you mind adding these constants to a new |
|
Can we rename DEFAULT_DECIMALS to NATIVE_DECIMALS and put it in src/spl/token/constants.py? |
Change constants location.
Useful Solana constants.
Happy to help. I have updated the PR; the constants are now in Solana directory. |
n3tn1nja
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @michaelhly!
I've added the LAMPORTS_PER_SOL and DEFAULT_DECIMALS constants to the library.
Given the popularity of this library and frequent reuse of these in scripts, it seemed beneficial to centralize them to the library to reduce redundancy and potential errors. This change can help make many codebases cleaner and more maintainable.
Thank you for considering this addition!