Skip to content

Commit

Permalink
Support podman in macOS
Browse files Browse the repository at this point in the history
With [a fix][1] in [podman v3.4.3][2], these commands now work as
expected in macOS. Potentially, it might make sense to version check
podman to ensure that the minimum version is met, but I'm not sure
that's needed because it's unlikely that people have an older version
installed _and_ wish to use this tool.

I'm unsure whether the commands work on Windows so I left the
unsupported version there compiling with the negation of the supported
flags.

[1]: containers/podman#12402
[2]: https://github.com/containers/podman/blob/4ba71f955a944790edda6e007e6d074009d437a7/RELEASE_NOTES.md#bugfixes-2
  • Loading branch information
michaelherold committed Mar 31, 2022
1 parent c7d121b commit 7dfef03
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 3 deletions.
2 changes: 1 addition & 1 deletion dive/image/podman/build.go
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// +build linux
// +build linux darwin

package podman

Expand Down
2 changes: 1 addition & 1 deletion dive/image/podman/cli.go
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// +build linux
// +build linux darwin

package podman

Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
// +build linux darwin

package podman

import (
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// +build !linux
// +build !linux,!darwin

package podman

Expand Down

0 comments on commit 7dfef03

Please sign in to comment.