-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configurable colours #39
Conversation
I have over four hours of meetings today (send help!), so I don't think I'll get to a code review today, but I'll look it over when I can. Thank you for your work on this. |
Looks like a good starting point, but can you include the branch name as configurable too? All the other colors render fine on a default instance of "terminal" (Pro theme) for Yosemite, except that the branch name is as black as the background. I'm not sure why the demo shows that the branch names are grey in the README. I'd really like to make them white. |
fd6bbbe
to
1342bd1
Compare
Ok, that last commit adds the ability to configure the colour of the branch reference and the symbol used to represent master (which I set as default as an italic m, just cause I like it |
Excellent! The only enhancement I can think of that works with the system you're building is to (later, of course) expose some generic themes. A light and a dark theme that work well for folks who are using a typical white on black/black on white theme. I imagine most are. That way you can skip the configuration file entirely and swap it out with a command line arg. export PS1="$PS1\$(git-radar --bash --theme=dark )" |
Hey -- didn't have time to do any code review but browsed around some of the updated files. I'll take @Droogans word it's ok! 😁 👍 |
Cool, I'll write some docs today and merge it. |
This pull request provides the ability to modify the colours used for the various parts of the prompt. It was requested in issue #12. It provides the option of using either ENV vars or an rc file at
~/.gitradarrc
.The only thing missing at the moment is documentation but it's 1am here so I'll do it in the morning.
@apas, @jackmaney, @jedsmith, @Droogans: code review?