Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an issue with zipOrAccumulate with two procedures. #112

Conversation

rhirai-line
Copy link

@rhirai-line rhirai-line commented Oct 28, 2024

PR for #111 .

I modified zipOrAccumulate with two procedures.
Previously each procedure was executed twice, but now it is executed only once.

@rhirai-line rhirai-line changed the title Fix an issue with zipOrAccumulate which provides two procedures. Fix an issue with zipOrAccumulate with two procedures. Oct 28, 2024
@michaelbull
Copy link
Owner

michaelbull commented Nov 2, 2024

Please can you rebase this change onto the latest commit of master (144c58e) to fix the CI issue.

@rhirai-line rhirai-line force-pushed the feature/111-fix-zipOrAccumulate branch from 07824ee to c539b6c Compare November 5, 2024 03:54
@rhirai-line
Copy link
Author

I've rebased this branch onto latest master.Thank You.

@eichisanden
Copy link
Contributor

@michaelbull
I have been waiting for this Pull Request to be merged, but why was it CLOSED?

@michaelbull
Copy link
Owner

michaelbull commented Nov 25, 2024

@eichisanden because it was merged into master: 03704eb

You can see it in this GitHub issues' history:

image

@eichisanden
Copy link
Contributor

@michaelbull I thought it was not merged because the pull request is Closed, sorry!

BTW, is there a version with this fix available on maven? Is it coming?

@michaelbull
Copy link
Owner

The SNAPSHOT version is built on every commit to master, so there should be a SNAPSHOT version with the latest change in that you can use from maven central (provided you have added the snapshot repository).

You can see a full list of the snapshot versions & artifacts here

@eichisanden
Copy link
Contributor

Thank you for kindly teaching me!!.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants