Skip to content

Commit

Permalink
[pkg/ottl] set `processor.transform.ConvertBetweenSumAndGaugeMetricCo…
Browse files Browse the repository at this point in the history
…ntext` as stable (open-telemetry#36216)

#### Description

Set the `processor.transform.ConvertBetweenSumAndGaugeMetricContext`
feature gate as stable

#### Link to tracking issue
Fixes
open-telemetry#34567

---------

Co-authored-by: Evan Bradley <[email protected]>
  • Loading branch information
2 people authored and michael-burt committed Nov 7, 2024
1 parent fdd021f commit cdf1e5a
Show file tree
Hide file tree
Showing 9 changed files with 31 additions and 377 deletions.
27 changes: 27 additions & 0 deletions .chloggen/transform-set-stable-gate.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
# Use this changelog template to create an entry for release notes.

# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
change_type: breaking

# The name of the component, or a single word describing the area of concern, (e.g. filelogreceiver)
component: pkg/ottl

# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
note: Promote `processor.transform.ConvertBetweenSumAndGaugeMetricContext` feature gate to Stable

# Mandatory: One or more tracking issues related to the change. You can use the PR number here if no issue exists.
issues: [36216]

# (Optional) One or more lines of additional information to render under the primary note.
# These lines will be padded with 2 spaces and then inserted directly into the document.
# Use pipe (|) for multiline entries.
subtext: This gate can no longer be disabled. The `convert_sum_to_gauge` and `convert_gauge_to_sum` may now only be used with the `metric` context.

# If your change doesn't affect end users or the exported elements of any package,
# you should instead start your pull request title with [chore] or use the "Skip Changelog" label.
# Optional: The change log or logs in which this entry should be included.
# e.g. '[user]' or '[user, api]'
# Include 'user' if the change is relevant to end users.
# Include 'api' if there is a change to a library API.
# Default: '[user]'
change_logs: []
4 changes: 0 additions & 4 deletions processor/transformprocessor/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -49,10 +49,6 @@ var _ component.Config = (*Config)(nil)
func (c *Config) Validate() error {
var errors error

if c.logger != nil && metrics.UseConvertBetweenSumAndGaugeMetricContext.IsEnabled() {
c.logger.Sugar().Infof("Metric conversion functions use metric context since %s is enabled. If your statements are not parsing, check if you're using the metrics conversion functions via the datapoint context.", metrics.UseConvertBetweenSumAndGaugeMetricContext.ID())
}

if len(c.TraceStatements) > 0 {
pc, err := common.NewTraceParserCollection(component.TelemetrySettings{Logger: zap.NewNop()}, common.WithSpanParser(traces.SpanFunctions()), common.WithSpanEventParser(traces.SpanEventFunctions()))
if err != nil {
Expand Down
3 changes: 0 additions & 3 deletions processor/transformprocessor/go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ module github.com/open-telemetry/opentelemetry-collector-contrib/processor/trans
go 1.22.0

require (
github.com/open-telemetry/opentelemetry-collector-contrib/internal/common v0.112.0
github.com/open-telemetry/opentelemetry-collector-contrib/internal/coreinternal v0.112.0
github.com/open-telemetry/opentelemetry-collector-contrib/internal/filter v0.112.0
github.com/open-telemetry/opentelemetry-collector-contrib/internal/pdatautil v0.112.0
Expand Down Expand Up @@ -100,8 +99,6 @@ replace github.com/open-telemetry/opentelemetry-collector-contrib/pkg/pdatatest

replace github.com/open-telemetry/opentelemetry-collector-contrib/pkg/golden => ../../pkg/golden

replace github.com/open-telemetry/opentelemetry-collector-contrib/internal/common => ../../internal/common

replace github.com/open-telemetry/opentelemetry-collector-contrib/internal/filter => ../../internal/filter

replace github.com/open-telemetry/opentelemetry-collector-contrib/internal/pdatautil => ../../internal/pdatautil

This file was deleted.

This file was deleted.

This file was deleted.

Loading

0 comments on commit cdf1e5a

Please sign in to comment.