Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for SimpleImage #6

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

Heriberto-Juarez
Copy link

Fixing a typo and adding support to simple image.

@Heriberto-Juarez
Copy link
Author

Now Im also adding support for linkTool

@miadabdi
Copy link
Owner

miadabdi commented Sep 6, 2022

@Heriberto-Juarez
I'm sorry, I am having a confusion over changes regarding simple-image,
Didn't this package support simple-image already?
I mean, I am suspecting what you mean by "adding support to simple image" is just changing the package to support image and simple-image at the same time.

Changes made for link-tool seems fine, I just need some explanation on what happened with "images part" of this pull request.
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants